[libcxx-commits] [PATCH] D132090: [1a/3][ASan][compiler-rt] API for double ended containers

[Tacet via Phabricator via libcxx-commits]

AdvenamTacet updated this revision to Diff 462264.
AdvenamTacet marked 2 inline comments as done.
AdvenamTacet added a comment.

Call to TestDoubleEndedContainer is now made.

Unnecessary check removed.

Annotations are fixed to pass the test and __sanitizer_verify_double_ended_contiguous_container
is modified to work with empty containers when beg != con_beg.

Locally, the test is failing on TestThrow, part not modified by that patch.

  a.out: contiguous_container.cpp:112: void TestThrow(): Assertion `!__asan_address_is_poisoned(x + 14)' failed.
  Aborted

Code there:

  void TestThrow() {
    char x[32];
    __sanitizer_annotate_contiguous_container(x, x + 32, x + 32, x + 14);
    assert(!__asan_address_is_poisoned(x + 13));
    assert(__asan_address_is_poisoned(x + 14));
    ThrowAndCatch();
    assert(!__asan_address_is_poisoned(x + 13));
    assert(!__asan_address_is_poisoned(x + 14)); // Line 112

I'm going to look at it closer, but `TestDoubleEndedContainer` passed, therefore I believe
fixed implementation is working in every case (and not only for deque).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132090/new/

https://reviews.llvm.org/D132090

Files:
  compiler-rt/include/sanitizer/common_interface_defs.h
  compiler-rt/lib/asan/asan_errors.cpp
  compiler-rt/lib/asan/asan_errors.h
  compiler-rt/lib/asan/asan_poisoning.cpp
  compiler-rt/lib/asan/asan_report.cpp
  compiler-rt/lib/asan/asan_report.h
  compiler-rt/lib/sanitizer_common/sanitizer_common_interface.inc
  compiler-rt/lib/sanitizer_common/sanitizer_interface_internal.h
  compiler-rt/test/asan/TestCases/contiguous_container.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D132090.462264.patch
Type: text/x-patch
Size: 31189 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220922/c1fd53b5/attachment-0001.bin>