[libcxx-commits] [PATCH] D132090: [1a/3][ASan][compiler-rt] API for double ended containers

[Vitaly Buka via Phabricator via libcxx-commits]

vitalybuka added a comment.

looks good in general, I will make another pass for details by tomorrow



================
Comment at: compiler-rt/test/asan/TestCases/contiguous_container.cpp:50
 
+#if _LIBCPP_CLANG_VER >= 16000
+// Define ASAN_SHADOW_GRANULARITY if granularity is different
----------------
we don't need version check as this code goes together with asan_poisoning.cpp and should not depend on compiler


================
Comment at: compiler-rt/test/asan/TestCases/contiguous_container.cpp:56
+
+void TestDoubleEndedContainer(size_t capacity) {
+  char *beg = new char[capacity];
----------------
I don't see TestDoubleEndedContainer is called


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132090/new/

https://reviews.llvm.org/D132090