[libcxx-commits] [PATCH] D132090: [1a/3][ASan][compiler-rt] API for double ended containers

[Vitaly Buka via Phabricator via libcxx-commits]

vitalybuka added inline comments.


================
Comment at: libcxx/include/__config:883
     __sanitizer_annotate_contiguous_container(const void*, const void*, const void*, const void*);
+extern "C" _LIBCPP_FUNC_VIS void __sanitizer_annotate_double_ended_contiguous_container(
+    const void*, const void*, const void*, const void*, const void*, const void*);
----------------
vitalybuka wrote:
> this should be in a separate patch, probably D132092
> 
> however we need to support the case when we build libcxx with older clang/compiler-rt when this function is not available
> maybe you land D132090 and after some time, if it's not reverted
> you land libcxx patch with  _LIBCPP_CLANG_VER check?
> 
> how about gcc? it uses the same runtime
Note: I assume that compiler-rt/clang version mismatch is possible, but is not required to support. I assume that libcxx clang mismatch is required to be supported.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132090/new/

https://reviews.llvm.org/D132090