[libcxx-commits] [PATCH] D132090: [1a/3][ASan][compiler-rt] API for double ended containers

[Vitaly Buka via Phabricator via libcxx-commits]

vitalybuka added inline comments.


================
Comment at: compiler-rt/include/sanitizer/common_interface_defs.h:229
+    const void *storage_beg, const void *storage_end, const void *old_container_beg,
+    const void *old_container_end, const void *new_container_beg, const void *new_container_end);
+/// Similar to <c>__sanitizer_annotate_contiguous_container</c>.
----------------
looks too long, please clang format


================
Comment at: compiler-rt/include/sanitizer/common_interface_defs.h:230
+    const void *old_container_end, const void *new_container_beg, const void *new_container_end);
+/// Similar to <c>__sanitizer_annotate_contiguous_container</c>.
+///
----------------
new line


================
Comment at: compiler-rt/lib/asan/asan_errors.h:346
+            tid, 10,
+            "bad-__sanitizer_annotate_double_ended_contiguous_container_front"),
+        stack(stack_),
----------------
-_front ?


================
Comment at: libcxx/include/__config:883
     __sanitizer_annotate_contiguous_container(const void*, const void*, const void*, const void*);
+extern "C" _LIBCPP_FUNC_VIS void __sanitizer_annotate_double_ended_contiguous_container(
+    const void*, const void*, const void*, const void*, const void*, const void*);
----------------
this should be in a separate patch, probably D132092

however we need to support the case when we build libcxx with older clang/compiler-rt when this function is not available
maybe you land D132090 and after some time, if it's not reverted
you land libcxx patch with  _LIBCPP_CLANG_VER check?

how about gcc? it uses the same runtime


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132090/new/

https://reviews.llvm.org/D132090