[libcxx-commits] [PATCH] D133122: [libc++] Shows the detailed compiler version info.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/utils/ci/run-buildbot:150-155
 
+# When not using the CXX environment variable it's a bit harder to determine
+# the compiler selected by CMake. This depends on CMake's platform specific
+# rules. The exact compiler version is only of interest when using nightly
+# builds. (They have additional version information not displayed by CMake.)
+# These builds are always selected by the environment variable.
----------------
IMO this comment doesn't pull its weight. It's useful to print the compiler version, no justification needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133122/new/

https://reviews.llvm.org/D133122