[libcxx-commits] [PATCH] D133122: [libc++] Shows the detailed compiler version info.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante created this revision.
Herald added a subscriber: mgorny.
Herald added a project: All.
ldionne added a comment.
Mordante updated this revision to Diff 459481.
Herald added a subscriber: arichardson.
Mordante published this revision for review.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

IMO we should do this in `run-buildbot` instead. We can add this to the phase at the beginning where we output the `--version` of various tools (`cmake`, `ninja`, etc.). We should be able to use something like `if [ ! -z "${CXX}" ]; then ${CXX} --version; fi`.


Mordante added a comment.

Use @ldionne's suggested approach.


The libc++ pre-commit CI uses Clang nightly builds. Currently it's not
possible to determine the exact version used since CMake doesn't show
this information by default. Instead use the --version flag to get this
information.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D133122

Files:
  libcxx/utils/ci/run-buildbot


Index: libcxx/utils/ci/run-buildbot
===================================================================
--- libcxx/utils/ci/run-buildbot
+++ libcxx/utils/ci/run-buildbot
@@ -148,6 +148,13 @@
 ${CMAKE} --version
 ${NINJA} --version
 
+# When not using the CXX environment variable it's a bit harder to determine
+# the compiler selected by CMake. This depends on CMake's platform specific
+# rules. The exact compiler version is only of interest when using nightly
+# builds. (They have additional version information not displayed by CMake.)
+# These builds are always selected by the environment variable.
+if [ ! -z "${CXX}" ]; then ${CXX} --version; fi
+
 case "${BUILDER}" in
 check-format)
     clean


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133122.459481.patch
Type: text/x-patch
Size: 706 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220912/72a19f7b/attachment.bin>