[libcxx-commits] [PATCH] D132943: [libc++] Remove MSVC code

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Sep 9 06:36:43 PDT 2022


ldionne accepted this revision.
ldionne added a comment.

Just to be clear -- I'm in favour of this, however I want to make sure that anyone reading this doesn't get the wrong impression. We *are* interested in supporting MSVC (although there is no current effort to do that AFAICT). This removal is not a statement of "not wanting to support MSVC", it's simply removing code that is dead, has been dead for we don't know how long, and likely doesn't work.

If we ever make an effort to port to MSVC (which I think would be interesting and maybe not even that difficult since we already support Windows), we should do it properly with CI to make sure it doesn't rot. Let's wait another week and ship this. If anything, we can always revert.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132943/new/

https://reviews.llvm.org/D132943



More information about the libcxx-commits mailing list