[libcxx-commits] [PATCH] D132943: [libc++] Remove MSVC code

Thu Sep 1 03:34:35 PDT 2022

philnik planned changes to this revision.
philnik added a comment.

In D132943#3759178 <https://reviews.llvm.org/D132943#3759178>, @Mordante wrote:

> In D132943#3758779 <https://reviews.llvm.org/D132943#3758779>, @philnik wrote:
>
>> In D132943#3758775 <https://reviews.llvm.org/D132943#3758775>, @Mordante wrote:
>>
>>> Has this diagnostic ever been in a released version of libc++?
>>> IMO having nobody noticing it for only 6 weeks seems too short to me.
>>
>> Yes, it's in LLVM 15. Though I would expect anybody who has a working configuration to track ToT fairly closely, since I think it would be quite an effort to update such a configuration only every release. How long do you think we should wait before removing the code?
>
> LLVM 15 hasn't been released yet. I think doing it a few months after the release would be better. Or is there an urgent reason for the removal?

Right, the release stuff takes a few months. I'll wait a bit longer.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132943/new/

https://reviews.llvm.org/D132943