[libcxx-commits] [PATCH] D134216: [SystemZ][z/OS] add code for hardware_concurrency()

Muiez Ahmed via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Oct 28 08:41:39 PDT 2022


muiez abandoned this revision.
muiez added a comment.

In D134216#3891898 <https://reviews.llvm.org/D134216#3891898>, @ldionne wrote:

> I am extremely concerned by the need to introduce these sorts of arcane implementation details in the library for z/OS, especially since we don't have a clear idea of where these patches are going to stop.
>
> libc++ is not a "low level system library". It's a library layered on top of C libraries and other standard (or mostly standard) APIs like POSIX and others. It's fine to have some amount of low level and platform specific stuff, but we're not going to implement from scratch APIs that should be provided by any decent OS.

Thanks for the feedback. I'll close this revision until we have an API for this on z/OS.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134216/new/

https://reviews.llvm.org/D134216



More information about the libcxx-commits mailing list