[libcxx-commits] [PATCH] D136683: [libc++] Only include_next C library headers when they exist

Tue Oct 25 08:45:19 PDT 2022

philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

In essence LGTM. As another PR, could we maybe add a minimal set of C headers that are required to build and test libc++ with `LIBCXX_ENABLE_LOCALIZATION=Off`, `LIBCXX_ENABLE_UNICODE=Off`, etc? That would allow us to track what we require the C implementation to provide and we can actually test against a minimal C library. If you think that's a good idea I'd be happy to work on that.

================
Comment at: libcxx/include/complex.h:28-31
+#else
+#  if __has_include_next(<complex.h>)
+#    include_next <complex.h>
+#  endif
----------------

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136683/new/

https://reviews.llvm.org/D136683