[libcxx-commits] [PATCH] D136683: [libc++] Only include_next C library headers when they exist

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Oct 25 07:13:52 PDT 2022


ldionne created this revision.
Herald added a project: All.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Some platforms don't provide all C library headers. In practice, libc++
only requires a few C library headers to exist, and only a few functions
on those headers. Missing functions that libc++ doesn't need for its own
implementation are handled properly by the using_if_exists attribute,
however a missing header is currently a hard error when we try to
do #include_next.

This patch should make libc++ more flexible on platforms that do not
provide C headers that libc++ doesn't actually require for its own
implementation. The only downside is that it may move some errors from
the #include_next point to later in the compilation if we actually try
to use something that isn't provided, which could be somewhat confusing.
However, these errors should be caught by folks trying to port libc++
over to a new platform (when running the libc++ test suite), not by end
users.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D136683

Files:
  libcxx/include/complex.h
  libcxx/include/ctype.h
  libcxx/include/errno.h
  libcxx/include/fenv.h
  libcxx/include/float.h
  libcxx/include/inttypes.h
  libcxx/include/limits.h
  libcxx/include/locale.h
  libcxx/include/math.h
  libcxx/include/setjmp.h
  libcxx/include/stdbool.h
  libcxx/include/stddef.h
  libcxx/include/stdint.h
  libcxx/include/stdio.h
  libcxx/include/stdlib.h
  libcxx/include/string.h
  libcxx/include/tgmath.h
  libcxx/include/wchar.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136683.470477.patch
Type: text/x-patch
Size: 6735 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20221025/327be439/attachment-0001.bin>


More information about the libcxx-commits mailing list