[libcxx-commits] [libcxx] 8e892c9 - [libc++] Improve error message for invalid allocators

[Nikolas Klauser via libcxx-commits]

Author: Nikolas Klauser
Date: 2022-10-16T00:37:35+02:00
New Revision: 8e892c9dd84a4734c1d5b1285035520f5fb96838

URL: https://github.com/llvm/llvm-project/commit/8e892c9dd84a4734c1d5b1285035520f5fb96838
DIFF: https://github.com/llvm/llvm-project/commit/8e892c9dd84a4734c1d5b1285035520f5fb96838.diff

LOG: [libc++] Improve error message for invalid allocators

Reviewed By: ldionne, #libc

Spies: libcxx-commits, rupprecht

Differential Revision: https://reviews.llvm.org/D135803

Added: 
    libcxx/test/libcxx/containers/sequences/vector/invalid_allocator.verify.cpp

Modified: 
    libcxx/include/__memory/allocator_traits.h

Removed: 
    


################################################################################
diff  --git a/libcxx/include/__memory/allocator_traits.h b/libcxx/include/__memory/allocator_traits.h
index 619fe112a1e34..6acc14aa23771 100644
--- a/libcxx/include/__memory/allocator_traits.h
+++ b/libcxx/include/__memory/allocator_traits.h
@@ -156,7 +156,8 @@ struct __has_rebind_other<_Tp, _Up, __void_t<typename _Tp::template rebind<_Up>:
 
 template <class _Tp, class _Up, bool = __has_rebind_other<_Tp, _Up>::value>
 struct __allocator_traits_rebind {
-    using type _LIBCPP_NODEBUG = typename _Tp::template rebind<_Up>::other;
+  static_assert(__has_rebind_other<_Tp, _Up>::value, "This allocator has to implement rebind");
+  using type _LIBCPP_NODEBUG = typename _Tp::template rebind<_Up>::other;
 };
 template <template <class, class...> class _Alloc, class _Tp, class ..._Args, class _Up>
 struct __allocator_traits_rebind<_Alloc<_Tp, _Args...>, _Up, true> {

diff  --git a/libcxx/test/libcxx/containers/sequences/vector/invalid_allocator.verify.cpp b/libcxx/test/libcxx/containers/sequences/vector/invalid_allocator.verify.cpp
new file mode 100644
index 0000000000000..abd33a07a6cd5
--- /dev/null
+++ b/libcxx/test/libcxx/containers/sequences/vector/invalid_allocator.verify.cpp
@@ -0,0 +1,28 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// Check that vector diagnoses an allocator which has to implement rebind with an appropriate error message
+
+#include <vector>
+
+class FooAllocator {
+ public:
+  using value_type = int;
+  FooAllocator() = default;
+
+  int* allocate(int num_objects);
+
+  void deallocate(int* ptr, int num_objects);
+
+  bool operator==(const FooAllocator&) const { return true; }
+  bool operator!=(const FooAllocator&) const { return false; }
+};
+
+void func() {
+  std::vector<int, FooAllocator> v; //expected-error-re@*:* {{{{(static_assert|static assertion)}} failed {{.*}}This allocator has to implement rebind}}
+}