[libcxx-commits] [PATCH] D131792: [libunwind] Remove __ANDROID_API__ < 18 workaround

[Shoaib Meenai via Phabricator via libcxx-commits]

smeenai added a comment.

Apologies for the delayed response here ... I was out of the office for a long time.

I completely understand the question around having to keep this workaround forever, and the burden induced by having to support older versions. I myself had a project I really cared about blocked for two years because of issues with old Android versions, and I'm sure all of you on the Android and NDK teams have many similar stories. At the same time, the reason we still support these old systems is because we have millions of users on them, which makes it really hard to leave them behind both from a business and personal perspective.

I'll start a conversation with our app teams about upping their minimum API requirements. I might be able to make a case for 19, but 21 would be a pretty hard sell (though I'd also love it cos it'd simplify a ton of things on our end too). When you say the next NDK release, according to https://github.com/android/ndk/wiki, that won't occur till Q3 2023, right? That gives us a lot of time to evaluate this, at least.

I'll just keep this around as a local patch in the meantime.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131792/new/

https://reviews.llvm.org/D131792