[libcxx-commits] [PATCH] D134221: [runtimes] Always define the cxx_shared, cxx_static & other targets

Wed Oct 12 06:35:53 PDT 2022

ldionne accepted this revision as: libc++, libc++abi, libunwind.
ldionne added a comment.
This revision is now accepted and ready to land.

In D134221#3850643 <https://reviews.llvm.org/D134221#3850643>, @daltenty wrote:

> In D134221#3850412 <https://reviews.llvm.org/D134221#3850412>, @ldionne wrote:
>
>> Rebase and address AIX issues.
>>
>> @daltenty I already had this update ready to go before you created D135699 <https://reviews.llvm.org/D135699>, but let me know if you'd
>> rather go with yours instead, which is in a separate patch. I have no preference but I did find that
>> my comment explaining the issue was a bit more detailed.
>
> LGTM, thanks! I agree, let's go with this (I can adjust D135699 <https://reviews.llvm.org/D135699> to include just adding the building of the static libraries)

Do you actually have to build static libraries? IMO it's fine to just set their name to avoid conflicts but not necessarily build them if you don't need them.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134221/new/

https://reviews.llvm.org/D134221