[libcxx-commits] [PATCH] D134221: [runtimes] Always define the cxx_shared, cxx_static & other targets

Tue Oct 11 14:00:41 PDT 2022

daltenty accepted this revision.
daltenty added a comment.

In D134221#3850412 <https://reviews.llvm.org/D134221#3850412>, @ldionne wrote:

> Rebase and address AIX issues.
>
> @daltenty I already had this update ready to go before you created D135699 <https://reviews.llvm.org/D135699>, but let me know if you'd
> rather go with yours instead, which is in a separate patch. I have no preference but I did find that
> my comment explaining the issue was a bit more detailed.

LGTM, thanks! I agree, let's go with this (I can adjust D135699 <https://reviews.llvm.org/D135699> to include just adding the building of the static libraries)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134221/new/

https://reviews.llvm.org/D134221