[libcxx-commits] [PATCH] D135180: [NFC][libc++] Moves transitive includes location.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Oct 4 11:06:50 PDT 2022


Mordante added a comment.

In D135180#3834249 <https://reviews.llvm.org/D135180#3834249>, @philnik wrote:

> Why would we want to do this? We don't include the normal headers outside the include guard, and AFAICT the only thing this changes is that the compiler potentially has to load the files more often just to do nothing. That shouldn't be a problem, since the compiler optimizes that AFAIK, but why even open the possibility?

I have a slight preference for the current location. But @ldionne preferred to have them completely at the end.
The compiler indeed has ways include optimizations, which we discovered while working on the transitive includes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135180/new/

https://reviews.llvm.org/D135180



More information about the libcxx-commits mailing list