[libcxx-commits] [PATCH] D135016: [libc++] Implement P1169R4 (static operator())

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.

More generally speaking, I think Eric's point is that we should also add tests that ensure that `std::function` works with a `static operator()`, regardless of CTAD. I agree with that, however I can see why that could be seen as separate from this patch.

But yes, I think we should definitely have runtime tests to check the interaction of `static operator()` and `std::function`.



================
Comment at: libcxx/test/std/utilities/function.objects/func.wrap/func.wrap.func/func.wrap.func.con/ctad.static.compile.pass.cpp:10
+// UNSUPPORTED: c++03, c++11, c++14
+// UNSUPPORTED: (c++17 || c++20) && !stdlib=libc++
+// ADDITIONAL_COMPILE_FLAGS: -Wno-c++2b-extensions
----------------
Why do we support this pre-C++23?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135016/new/

https://reviews.llvm.org/D135016