[libcxx-commits] [PATCH] D135016: [libc++] Implement P1169R4 (static operator())

Sun Oct 2 12:30:59 PDT 2022

EricWF added a comment.

In D135016#3829434 <https://reviews.llvm.org/D135016#3829434>, @philnik wrote:

> In D135016#3829346 <https://reviews.llvm.org/D135016#3829346>, @EricWF wrote:
>
>> this needs real tests. compile only tests are not sufficient
>
> Why? CTAD is a compile-time feature. There is no runtime to test.

Because people run their code sometimes. And we should too.
And because writing holistic tests catches more than just bugs in the change.
They can catch compiler frontend and backend bugs, latent bugs in existing code, etc.

Because shipping a bug in libc++ is such a high cost, it's worth it to test more than the bare minimum.

Yes, it deduces to the correct type. But does it correctly call the constructor and store the pointer? It should, but does it?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135016/new/

https://reviews.llvm.org/D135016