[libcxx-commits] [PATCH] D133535: [libc++] Suppress -Wctad-maybe-unsupported on types w/o deduction guides

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D133535#3828360 <https://reviews.llvm.org/D133535#3828360>, @ldionne wrote:

>> I like the format contexts also to keep using CTAD, I don't feel writing the template types there makes the code easier to understand.
>
> Instead, I would suggest going through all the types in `format` and considering which ones it makes sense to use CTAD with. Does that sound reasonable? This patch is only trying to get the library+tests compiling with the warning enabled with as little changes as possible.

These types are public types, so we can't just add CTAD to them. But I wouldn't mind to commit the format part as-is and afterwards I rework the format patch in a followup. (This followup will be a partial revert of this commit.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133535/new/

https://reviews.llvm.org/D133535