[libcxx-commits] [PATCH] D131868: [libc++][NFC] Refactor enable_ifs in vector

Mon Oct 3 07:01:32 PDT 2022

ldionne added a comment.

In D131868#3830628 <https://reviews.llvm.org/D131868#3830628>, @ldionne wrote:

> I am 90% certain that this caused the following change of behavior: https://godbolt.org/z/WKEadqf8e. Long story short, constructing a vector with iterators with a mismatched constness used to work, and now it doesn't anymore. GCC doesn't support it either.
>
> @philnik Since this is almost certainly unintended, can you please figure out what the valid standard behavior is here and add a test if the standard mandates that?

Also, I noticed because it broke some code. It did not result in any significant breakage, but if the new behavior is the correct one and we keep it, we should add a release note just as a heads up.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131868/new/

https://reviews.llvm.org/D131868