[libcxx-commits] [PATCH] D131425: [libc++] Remove workarounds for systems with tortuous include requirements

[Mike Hommey via Phabricator via libcxx-commits]

glandium added a comment.

Also getting errors when building compiler-rt standalone:

  [task 2022-11-21T21:07:28.272Z] In file included from /builds/worker/fetches/llvm-project/libcxx/src/mutex.cpp:11:
  [task 2022-11-21T21:07:28.272Z] In file included from include/c++/v1/mutex:192:
  [task 2022-11-21T21:07:28.272Z] In file included from include/c++/v1/__mutex_base:20:
  [task 2022-11-21T21:07:28.272Z] In file included from include/c++/v1/system_error:154:
  [task 2022-11-21T21:07:28.272Z] In file included from include/c++/v1/string:561:
  [task 2022-11-21T21:07:28.272Z] In file included from include/c++/v1/__string/char_traits.h:24:
  [task 2022-11-21T21:07:28.272Z] include/c++/v1/cstdio:160:9: error: target of using declaration conflicts with declaration already in scope
  [task 2022-11-21T21:07:28.272Z] using ::remove _LIBCPP_USING_IF_EXISTS;
  [task 2022-11-21T21:07:28.272Z]         ^
  [task 2022-11-21T21:07:28.272Z] include/c++/v1/cstdio:160:1: note: target of using declaration
  [task 2022-11-21T21:07:28.272Z] using ::remove _LIBCPP_USING_IF_EXISTS;
  [task 2022-11-21T21:07:28.272Z] ^
  [task 2022-11-21T21:07:28.272Z] include/c++/v1/__algorithm/remove.h:25:1: note: conflicting declaration
  [task 2022-11-21T21:07:28.272Z] remove(_ForwardIterator __first, _ForwardIterator __last, const _Tp& __value)
  [task 2022-11-21T21:07:28.272Z] ^
  [task 2022-11-21T21:07:28.272Z] In file included from /builds/worker/fetches/llvm-project/libcxx/src/mutex.cpp:11:
  [task 2022-11-21T21:07:28.272Z] In file included from include/c++/v1/mutex:192:
  [task 2022-11-21T21:07:28.272Z] In file included from include/c++/v1/__mutex_base:20:
  [task 2022-11-21T21:07:28.272Z] In file included from include/c++/v1/system_error:154:
  [task 2022-11-21T21:07:28.272Z] In file included from include/c++/v1/string:561:
  [task 2022-11-21T21:07:28.272Z] include/c++/v1/__string/char_traits.h:81:26: error: use of undeclared identifier 'EOF'
  [task 2022-11-21T21:07:28.272Z]         {return int_type(EOF);}
  [task 2022-11-21T21:07:28.272Z]                          ^
  [task 2022-11-21T21:07:28.272Z] include/c++/v1/__string/char_traits.h:80:47: error: no return statement in constexpr function
  [task 2022-11-21T21:07:28.272Z]     static inline _LIBCPP_CONSTEXPR int_type  eof() _NOEXCEPT
  [task 2022-11-21T21:07:28.272Z]                                               ^
  [task 2022-11-21T21:07:28.272Z] include/c++/v1/__string/char_traits.h:257:26: error: use of undeclared identifier 'EOF'
  [task 2022-11-21T21:07:28.272Z]         {return int_type(EOF);}
  [task 2022-11-21T21:07:28.272Z]                          ^
  [task 2022-11-21T21:07:28.272Z] include/c++/v1/__string/char_traits.h:256:47: error: no return statement in constexpr function
  [task 2022-11-21T21:07:28.272Z]     static inline _LIBCPP_CONSTEXPR int_type  eof() _NOEXCEPT
  [task 2022-11-21T21:07:28.272Z]                                               ^
  [task 2022-11-21T21:07:28.272Z] include/c++/v1/__string/char_traits.h:482:26: error: use of undeclared identifier 'EOF'
  [task 2022-11-21T21:07:28.272Z]         {return int_type(EOF);}
  [task 2022-11-21T21:07:28.272Z]                          ^
  [task 2022-11-21T21:07:28.272Z] include/c++/v1/__string/char_traits.h:481:38: error: no return statement in constexpr function
  [task 2022-11-21T21:07:28.272Z]     static inline constexpr int_type eof() noexcept
  [task 2022-11-21T21:07:28.272Z]                                      ^
  [task 2022-11-21T21:07:28.272Z] 7 errors generated.
  [task 2022-11-21T21:07:28.577Z] [880/906] Building CXX object libcxx/src/CMakeFiles/cxx_static.dir/random_shuffle.cpp.o


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131425/new/

https://reviews.llvm.org/D131425