[libcxx-commits] [PATCH] D131425: [libc++] Remove workarounds for systems with tortuous include requirements

[Gulfem Savrun Yeniceri via Phabricator via libcxx-commits]

gulfem added a comment.

We started seeing failures while compiling some libcxx/src/ files:

  FAILED: libcxx/src/CMakeFiles/cxx_static.dir/barrier.cpp.o 
  /b/s/w/ir/cache/goma/client/gomacc /b/s/w/ir/x/w/staging/llvm_build/./bin/clang++ --target=aarch64-unknown-linux-gnu --sysroot=/b/s/w/ir/x/w/cipd/linux -DLIBCXX_BUILDING_LIBCXXABI -D_LIBCPP_BUILDING_LIBRARY -D_LIBCPP_DISABLE_NEW_DELETE_DEFINITIONS -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_LINK_PTHREAD_LIB -D_LIBCPP_LINK_RT_LIB -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/s/w/ir/x/w/llvm-llvm-project/libcxx/src -I/b/s/w/ir/x/w/staging/llvm_build/include/c++/v1 -I/b/s/w/ir/x/w/staging/llvm_build/include/aarch64-unknown-linux-gnu/c++/v1 -I/b/s/w/ir/x/w/llvm-llvm-project/libcxxabi/include --target=aarch64-unknown-linux-gnu -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -ffile-prefix-map=/b/s/w/ir/x/w/staging/llvm_build/runtimes/runtimes-aarch64-unknown-linux-gnu-bins=../staging/llvm_build/runtimes/runtimes-aarch64-unknown-linux-gnu-bins -ffile-prefix-map=/b/s/w/ir/x/w/llvm-llvm-project/= -no-canonical-prefixes -O2 -g  -UNDEBUG -faligned-allocation -nostdinc++ -fvisibility-inlines-hidden -fvisibility=hidden -Wall -Wextra -W -Wwrite-strings -Wno-unused-parameter -Wno-long-long -Werror=return-type -Wextra-semi -Wundef -Wformat-nonliteral -Wno-user-defined-literals -Wno-covered-switch-default -Wno-suggest-override -Wno-error -std=c++20 -MD -MT libcxx/src/CMakeFiles/cxx_static.dir/barrier.cpp.o -MF libcxx/src/CMakeFiles/cxx_static.dir/barrier.cpp.o.d -o libcxx/src/CMakeFiles/cxx_static.dir/barrier.cpp.o -c /b/s/w/ir/x/w/llvm-llvm-project/libcxx/src/barrier.cpp
  In file included from /b/s/w/ir/x/w/llvm-llvm-project/libcxx/src/barrier.cpp:14:
  In file included from /b/s/w/ir/x/w/staging/llvm_build/include/c++/v1/thread:90:
  In file included from /b/s/w/ir/x/w/staging/llvm_build/include/c++/v1/__mutex_base:20:
  In file included from /b/s/w/ir/x/w/staging/llvm_build/include/c++/v1/system_error:154:
  In file included from /b/s/w/ir/x/w/staging/llvm_build/include/c++/v1/string:561:
  In file included from /b/s/w/ir/x/w/staging/llvm_build/include/c++/v1/__string/char_traits.h:24:
  /b/s/w/ir/x/w/staging/llvm_build/include/c++/v1/cstdio:160:9: error: target of using declaration conflicts with declaration already in scope
  using ::remove _LIBCPP_USING_IF_EXISTS;
          ^
  /b/s/w/ir/x/w/staging/llvm_build/include/c++/v1/cstdio:160:1: note: target of using declaration
  using ::remove _LIBCPP_USING_IF_EXISTS;
  ^
  /b/s/w/ir/x/w/staging/llvm_build/include/c++/v1/__algorithm/remove.h:25:1: note: conflicting declaration
  remove(_ForwardIterator __first, _ForwardIterator __last, const _Tp& __value)
  ^
  In file included from /b/s/w/ir/x/w/llvm-llvm-project/libcxx/src/barrier.cpp:14:
  In file included from /b/s/w/ir/x/w/staging/llvm_build/include/c++/v1/thread:90:
  In file included from /b/s/w/ir/x/w/staging/llvm_build/include/c++/v1/__mutex_base:20:
  In file included from /b/s/w/ir/x/w/staging/llvm_build/include/c++/v1/system_error:154:
  In file included from /b/s/w/ir/x/w/staging/llvm_build/include/c++/v1/string:561:
  /b/s/w/ir/x/w/staging/llvm_build/include/c++/v1/__string/char_traits.h:81:26: error: use of undeclared identifier 'EOF'
          {return int_type(EOF);}
                           ^
  /b/s/w/ir/x/w/staging/llvm_build/include/c++/v1/__string/char_traits.h:80:47: error: no return statement in constexpr function
      static inline _LIBCPP_CONSTEXPR int_type  eof() _NOEXCEPT
                                                ^
  /b/s/w/ir/x/w/staging/llvm_build/include/c++/v1/__string/char_traits.h:257:26: error: use of undeclared identifier 'EOF'
          {return int_type(EOF);}
                           ^
  /b/s/w/ir/x/w/staging/llvm_build/include/c++/v1/__string/char_traits.h:256:47: error: no return statement in constexpr function
      static inline _LIBCPP_CONSTEXPR int_type  eof() _NOEXCEPT
                                                ^
  /b/s/w/ir/x/w/staging/llvm_build/include/c++/v1/__string/char_traits.h:482:26: error: use of undeclared identifier 'EOF'
          {return int_type(EOF);}
                           ^
  /b/s/w/ir/x/w/staging/llvm_build/include/c++/v1/__string/char_traits.h:481:38: error: no return statement in constexpr function
      static inline constexpr int_type eof() noexcept
                                       ^
  7 errors generated.

https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8796880526532247985/+/u/clang/build/stdout


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131425/new/

https://reviews.llvm.org/D131425