[libcxx-commits] [PATCH] D138069: [libc++] Don't pass the allocator in substr()

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.

LGTM, after addressing all review comments.



================
Comment at: libcxx/test/std/strings/basic.string/string.cons/substr.allocator.pass.cpp:21
+      string str((alloc(&stats)));
+      // Before C++17 the above constructor call may generate a call to the move constructor of the allocator
+      stats = test_allocator_statistics();
----------------
This comment sounds like this test tests libc++ specific behaviour. Can you add some guards to the libc++ specific tests so it will pass of other Standard libraries too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138069/new/

https://reviews.llvm.org/D138069