[libcxx-commits] [PATCH] D138069: [libc++] Don't pass the allocator in substr()

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM w/ comment. Also please rebase and get a green CI run.



================
Comment at: libcxx/test/std/strings/basic.string/string.cons/substr.allocator.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
I think this should be added to `libcxx/test/std/strings/basic.string/string.ops/string_substr/substr.pass.cpp` instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138069/new/

https://reviews.llvm.org/D138069