[libcxx-commits] [PATCH] D137502: [libc++][math.h] move #undefs to the top and guard explicitly against MSVCRT instead
Eric Fiselier via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Nov 21 09:42:46 PST 2022
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
This changes behavior.
Currently libc++ only provides its own definitions of a math function if there's a macro which is normally used to define it.
Now libc++ always provides those overloads. That could cause redefinition errors.
I know there's been a lot of churn in this header recently , so maybe the diff I'm reading is out of date, but please verify that's the case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137502/new/
https://reviews.llvm.org/D137502
More information about the libcxx-commits
mailing list