[libcxx-commits] [PATCH] D137502: [libc++][math.h] move #undefs to the top and guard explicitly against MSVCRT instead

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM pending CI too.

All in all, this whole stack is pretty much a NFC refactoring, but it makes things a lot nicer. Thanks!



================
Comment at: libcxx/include/math.h:304-306
+#    ifdef fpclassify
+#      undef fpclassify
+#    endif // fpclassify
----------------
Why isn't this below?


================
Comment at: libcxx/include/math.h:323
+#      undef isfinite
+#    endif // isfinite
+
----------------
Here and for all the other ones. We don't gain anything from these comments anymore, they just clutter the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137502/new/

https://reviews.llvm.org/D137502