[libcxx-commits] [PATCH] D136683: [libc++] Only include_next C library headers when they exist

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Nov 15 10:33:30 PST 2022


ldionne added a comment.

In D136683#3928129 <https://reviews.llvm.org/D136683#3928129>, @thakis wrote:

> It doesn't. But from the error message, it looks like it shouldn't matter (?)
>
> My reading of the error output is that this test tests the error message that occurs if the c++ headers aren't present. Previously we'd say "file not found", but now we say "reference to unresolved using declaration" due to not including some C header.
>
> Maybe I misunderstood what's happening though.

Well that build picked up the latest libc++ headers, so I guess it's at least doing a bootstrapping build and then using check-clang? I don't even know if Clang will use the just-built libc++ for testing when doing a bootstrapping build.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136683/new/

https://reviews.llvm.org/D136683



More information about the libcxx-commits mailing list