[libcxx-commits] [PATCH] D136683: [libc++] Only include_next C library headers when they exist

[Nico Weber via Phabricator via libcxx-commits]

thakis added a comment.

In D136683#3928074 <https://reviews.llvm.org/D136683#3928074>, @ldionne wrote:

> In D136683#3928001 <https://reviews.llvm.org/D136683#3928001>, @ldionne wrote:
>
>> In D136683#3927871 <https://reviews.llvm.org/D136683#3927871>, @thakis wrote:
>>
>>> It it possible that this caused this check-clang failure: http://45.33.8.238/macm1/48659/step_7.txt ?
>>
>> How does that bot configure the build with CMake?
>
> @thakis To make sure you see this.

It doesn't. But from the error message, it looks like it shouldn't matter (?)

My reading of the error output is that this test tests the error message that occurs if the c++ headers aren't present. Previously we'd say "file not found", but now we say "reference to unresolved using declaration" due to not including some C header.

Maybe I misunderstood what's happening though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136683/new/

https://reviews.llvm.org/D136683