[libcxx-commits] [PATCH] D137759: [libc++] Add a libc++ CI pipeline specific to Clang changes

[Louis Dionne via Phabricator via libcxx-commits]

ldionne marked an inline comment as done.
ldionne added inline comments.


================
Comment at: libcxx/utils/ci/buildkite-pipeline-clang.yml:50
+    env:
+        LLVM_SYMBOLIZER_PATH: "/usr/bin/llvm-symbolizer-${LLVM_HEAD_VERSION}" # TODO: Should we build that from scratch?
+        CLANG_CRASH_DIAGNOSTICS_DIR: "crash_diagnostics"
----------------
Mordante wrote:
> Isn't it build by default?
No, I don't think it is.


================
Comment at: libcxx/utils/ci/generate-buildkite-pipeline:17
+elif git diff --name-only HEAD~1 | grep -q -E "^clang/"; then
+  cat libcxx/utils/ci/buildkite-pipeline-clang.yml
+fi
----------------
Mordante wrote:
> Note when there are changes to clang and libc++ this pipeline isn't executed. This might be an issue:
> - A clang modular build change affects libc++
> - libc++ is fixed and the Clang modular build is no longer tested, so it's unclear whether the fix works
> 
> Should we instead have one build script and set environment variable which CI test should be executed?
I agree. Trying something out in https://reviews.llvm.org/D138042.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137759/new/

https://reviews.llvm.org/D137759