[libcxx-commits] [PATCH] D137759: [libc++] Add a libc++ CI pipeline specific to Clang changes

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Nice! Some nits. But I think we need to make sure that change to both Clang and libc++ still run the Clang CI.



================
Comment at: libcxx/utils/ci/buildkite-pipeline-clang.yml:50
+    env:
+        LLVM_SYMBOLIZER_PATH: "/usr/bin/llvm-symbolizer-${LLVM_HEAD_VERSION}" # TODO: Should we build that from scratch?
+        CLANG_CRASH_DIAGNOSTICS_DIR: "crash_diagnostics"
----------------
Isn't it build by default?


================
Comment at: libcxx/utils/ci/buildkite-pipeline-clang.yml:83
+
+  - label: "Modules"
+    commands:
----------------
To avoid confusion with C++20 modules.


================
Comment at: libcxx/utils/ci/generate-buildkite-pipeline:17
+elif git diff --name-only HEAD~1 | grep -q -E "^clang/"; then
+  cat libcxx/utils/ci/buildkite-pipeline-clang.yml
+fi
----------------
Note when there are changes to clang and libc++ this pipeline isn't executed. This might be an issue:
- A clang modular build change affects libc++
- libc++ is fixed and the Clang modular build is no longer tested, so it's unclear whether the fix works

Should we instead have one build script and set environment variable which CI test should be executed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137759/new/

https://reviews.llvm.org/D137759