[libcxx-commits] [PATCH] D137870: [CMake][compiler-rt] Don't load LLVM config in the runtimes build

[Petr Hosek via Phabricator via libcxx-commits]

phosek added inline comments.


================
Comment at: compiler-rt/CMakeLists.txt:82
 
-  load_llvm_config()
+  if (NOT LLVM_RUNTIMES_BUILD)
+    load_llvm_config()
----------------
mstorsjo wrote:
> Isn’t this condition unnecessary? This is in a block guarded with `if (COMPILER_RT_STANDALONE_BUILD)`, and if that’s true, `LLVM_RUNTIMES_BUILD` won’t be set?
We currently set `COMPILER_RT_STANDALONE_BUILD` in the runtimes build, see https://github.com/llvm/llvm-project/blob/f53fde8e150553c194b3325fe2781775aa40ac3a/runtimes/CMakeLists.txt#L183. I'd like to eventually remove that, but we need to do a bunch of cleanup first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137870/new/

https://reviews.llvm.org/D137870