[libcxx-commits] [PATCH] D137870: [CMake][compiler-rt] Don't load LLVM config in the runtimes build

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: compiler-rt/CMakeLists.txt:82
 
-  load_llvm_config()
+  if (NOT LLVM_RUNTIMES_BUILD)
+    load_llvm_config()
----------------
Isn’t this condition unnecessary? This is in a block guarded with `if (COMPILER_RT_STANDALONE_BUILD)`, and if that’s true, `LLVM_RUNTIMES_BUILD` won’t be set?


================
Comment at: compiler-rt/lib/builtins/CMakeLists.txt:28
 
-  load_llvm_config()
+  if (NOT LLVM_RUNTIMES_BUILD)
+    load_llvm_config()
----------------
Ditto here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137870/new/

https://reviews.llvm.org/D137870