[libcxx-commits] [PATCH] D126303: [libc++] Use Python subprocess instead of libc++'s own utilities

[Louis Dionne via Phabricator via libcxx-commits]

ldionne marked 2 inline comments as done.
ldionne added inline comments.


================
Comment at: libcxx/utils/libcxx/sym_check/util.py:69
         return symbol
-    out, _, exit_code = libcxx.util.executeCommandVerbose(
-        [_cppfilt_exe], input=symbol)
-    if exit_code != 0:
+    result = subprocess.run([_cppfilt_exe], input=symbol)
+    if result.returncode != 0:
----------------
EricWF wrote:
> EricWF wrote:
> > I believe this needs `capture_output=True` to work.
> > 
> > Has this been tested?
> Oh, and I think it's missing a `.decode()` call as well.
I did run the `check-cxx-abilist` target, which should run this unless mistaken.

EDIT: Well, it turns out I was mistaken! This is only called when there *is* a difference in the two ABI lists, and I had only tested with matching ABI lists. Fixed now, thanks for the catch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126303/new/

https://reviews.llvm.org/D126303