[libcxx-commits] [PATCH] D126303: [libc++] Use Python subprocess instead of libc++'s own utilities

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF added inline comments.


================
Comment at: libcxx/utils/libcxx/sym_check/util.py:69
         return symbol
-    out, _, exit_code = libcxx.util.executeCommandVerbose(
-        [_cppfilt_exe], input=symbol)
-    if exit_code != 0:
+    result = subprocess.run([_cppfilt_exe], input=symbol)
+    if result.returncode != 0:
----------------
EricWF wrote:
> I believe this needs `capture_output=True` to work.
> 
> Has this been tested?
Oh, and I think it's missing a `.decode()` call as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126303/new/

https://reviews.llvm.org/D126303