[libcxx-commits] [PATCH] D125184: [libc++] fix std::to_string() crashing in debug mode

[Luboš Luňák via Phabricator via libcxx-commits]

llunak marked 2 inline comments as done.
llunak added a comment.

In D125184#3514289 <https://reviews.llvm.org/D125184#3514289>, @Mordante wrote:

> I agree this is worth fixing, but I'm not convinced that this solution is safe and doesn't lead to ODR violations when different translation units are compiled with different values of `_LIBCPP_DEBUG_LEVEL`.

As you can see in the abi check lists, the debug functions are in a different namespace, so technically they are different functions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125184/new/

https://reviews.llvm.org/D125184