[libcxx-commits] [PATCH] D125184: [libc++] fix std::to_string() crashing in debug mode

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a reviewer: ldionne.
Mordante added a comment.

I agree this is worth fixing, but I'm not convinced that this solution is safe and doesn't lead to ODR violations when different translation units are compiled with different values of `_LIBCPP_DEBUG_LEVEL`. I'll leave the review to @ldionne.



================
Comment at: libcxx/include/string:4529
+#else
+inline namespace debug
+{
----------------
Please use an __ugly_name.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125184/new/

https://reviews.llvm.org/D125184