[libcxx-commits] [PATCH] D124789: [libc++] Find a clang-format everybody is happy with

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri May 6 10:18:24 PDT 2022


ldionne added inline comments.


================
Comment at: libcxx/include/__ranges/lazy_split_view.h:407
+      if constexpr (!forward_range<_Base>)
+      {
+        if constexpr (_Pattern::size() == 0)
----------------
I have a strong preference for keeping the `{` on the same line as the `if` (same for `class` and for functions). We don't have a 100% consistent way of doing this right now, but I think that's the precedent we should set going forward.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124789/new/

https://reviews.llvm.org/D124789



More information about the libcxx-commits mailing list