[libcxx-commits] [PATCH] D124789: [libc++] Find a clang-format everybody is happy with

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik updated this revision to Diff 426526.
philnik added a comment.

- Add a few requires examples

The formatting for `requires` clauses still isn't perfect, but I think these problems can mostly be worked around by adding parentheses around the clause itself. It isn't perfect but I think it's not much of a readability decrease. It's kind-of changing code for the tool to be happy (which I agree isn't a good thing) but I think in this case it's acceptable. IMO the gains of having actually consistent formatting outweighs the cost of adding parantheses in a few places.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124789/new/

https://reviews.llvm.org/D124789

Files:
  libcxx/.clang-format
  libcxx/include/__ranges/lazy_split_view.h
  libcxx/include/__ranges/zip_view.h
  libcxx/include/string
  libcxx/utils/ci/buildkite-pipeline.yml

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124789.426526.patch
Type: text/x-patch
Size: 345423 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220502/ef2be470/attachment-0001.bin>