[libcxx-commits] [PATCH] D122257: [libc++] Fix undefined behavior in `std::filebuf`

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/test/std/input.output/file.streams/fstreams/filebuf.assign/nonmember_swap_min.pass.cpp:12-14
+// FIXME: This test fails on Windows for some reason, but even before the swap,
+//        which is what we want to test here.
+// UNSUPPORTED: target={{.+}}-windows-{{.+}}
----------------
ldionne wrote:
> Also, you should make this `XFAIL: LIBCXX-WINDOWS-FIXME` if you can't figure it out or reproduce, and @mstorsjo might be able to help.
Don't make it `LIBCXX-WINDOWS-FIXME`, we don't want to add more of those. They were meant to only be used for the initial batch to get the testsuite working in such configs. We should be able to get rid of them and finally close https://github.com/llvm/llvm-project/issues/32077 real soon now, I'm just waiting for a CI runner upgrade)

A plain `XFAIL` with such a target triple (or just `XFAIL: windows` works too), with a `FIXME` comment, should be fine. But I can see if I can have a look at it...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122257/new/

https://reviews.llvm.org/D122257