[libcxx-commits] [PATCH] D122257: [libc++] Fix undefined behavior in `std::filebuf`

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Mar 28 12:01:02 PDT 2022


ldionne added a subscriber: mstorsjo.
ldionne added inline comments.


================
Comment at: libcxx/test/std/input.output/file.streams/fstreams/filebuf.assign/nonmember_swap_min.pass.cpp:12-14
+// FIXME: This test fails on Windows for some reason, but even before the swap,
+//        which is what we want to test here.
+// UNSUPPORTED: target={{.+}}-windows-{{.+}}
----------------
Also, you should make this `XFAIL: LIBCXX-WINDOWS-FIXME` if you can't figure it out or reproduce, and @mstorsjo might be able to help.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122257/new/

https://reviews.llvm.org/D122257



More information about the libcxx-commits mailing list