[libcxx-commits] [PATCH] D121435: [libc++] Canonicalize the ranges results and their tests

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

Nice cleanup! LGTM after improving the commit message. Since @var-const had some remarks I leave the final approval to him.



================
Comment at: libcxx/include/__algorithm/in_in_out_result.h:23
 
-#if _LIBCPP_STD_VER > 17 && !defined(_LIBCPP_HAS_NO_INCOMPLETE_RANGES)
+#if _LIBCPP_STD_VER > 17
 
----------------
I'm not entirely up-to-date to what we do and don't enable from ranges. So I assume this is intentionally, but please add it to the commit message.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121435/new/

https://reviews.llvm.org/D121435