[libcxx-commits] [PATCH] D121435: [libc++] Canonicalize the ranges results and their tests

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/test/std/algorithms/algorithms.results/in_out_result.pass.cpp:40
-    std::ranges::in_out_result<long, long>>);
-static_assert(std::is_convertible_v<const std::ranges::in_out_result<int, int>&&,
-    std::ranges::in_out_result<long, long>>);
----------------
var-const wrote:
> Question: is it okay to remove the tests for rvalue references?
What do you mean? They are in lines 43 and 44. Or am I missing something?


================
Comment at: libcxx/test/std/algorithms/algorithms.results/in_out_result.pass.cpp:88
   {
-    struct CopyOnly {
-      int value = 0;
----------------
var-const wrote:
> I presume you find this test overkill, but just want to make sure.
Yes, I don't really see what it would catch. If you want to keep it I can add it to the other tests too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121435/new/

https://reviews.llvm.org/D121435