[libcxx-commits] [PATCH] D110005: [WIP][CMake] Unify variable names

[Petr Hosek via Phabricator via libcxx-commits]

phosek added a comment.

In D110005#3406655 <https://reviews.llvm.org/D110005#3406655>, @ldionne wrote:

> My naming suggestion wasn't meant to stall this effort. I still have a slight preference for mentioning `_COMPILER_` in the name of these variables, but I don't care strongly enough to block this.
> I also think we'll want to lift these checks even further into `runtimes/` to simplify the code, but that's certainly a separate effort.

Yes, the next step I had planned after this is to lift https://github.com/llvm/llvm-project/blob/df209b8038f3803621e96799f5c43e9145448e10/libcxx/cmake/Modules/HandleLibcxxFlags.cmake to `runtimes/cmake/Modules`, and then replace https://github.com/llvm/llvm-project/blob/df209b8038f3803621e96799f5c43e9145448e10/libcxxabi/cmake/Modules/HandleLibcxxabiFlags.cmake and https://github.com/llvm/llvm-project/blob/df209b8038f3803621e96799f5c43e9145448e10/libunwind/cmake/Modules/HandleLibunwindFlags.cmake (and eventually also https://github.com/llvm/llvm-project/blob/main/compiler-rt/cmake/Modules/CompilerRTUtils.cmake but that's going to take more effort). Once this change lands, those changes should be effectively no-ops.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110005/new/

https://reviews.llvm.org/D110005