[libcxx-commits] [PATCH] D110005: [WIP][CMake] Unify variable names

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.

My naming suggestion wasn't meant to stall this effort. I still have a slight preference for mentioning `_COMPILER_` in the name of these variables, but I don't care strongly enough to block this. I also think we'll want to lift these checks even further into `runtimes/` to simplify the code, but that's certainly a separate effort.

I am fine with this as-is so I'll lift the hard "requires-changes" on the runtimes, but please wait to see whether others who had commented are fine too before shipping.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110005/new/

https://reviews.llvm.org/D110005