[libcxx-commits] [PATCH] D121647: [runtimes] Detect changes to Tests.cmake

Joel E. Denny via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 24 10:41:22 PDT 2022


jdenny added subscribers: jdoerfert, JonChesterfield.
jdenny added a comment.

In D121647#3396314 <https://reviews.llvm.org/D121647#3396314>, @jdenny wrote:

> The version of this patch that landed did not fix the openmp problem caused by D121276 <https://reviews.llvm.org/D121276>.  I backed it out (locally) and applied the version that I originally tested on 3/15, and all seems fine (that is, check-all includes openmp tests).  I'm testing at 3edec279dfa7 <https://reviews.llvm.org/rG3edec279dfa7a17ad60d8d2f108ebdca2f2ea845>.

@phosek I'm concerned I wasn't clear here: things are still broken upstream.  check-all still doesn't include openmp tests.

The May 15 version of this patch <https://reviews.llvm.org/D121647?id=415336> does fix it.  Can you apply something more like it?

Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121647/new/

https://reviews.llvm.org/D121647



More information about the libcxx-commits mailing list