[libcxx-commits] [PATCH] D121700: [libc++][tests] Use CMake provided paths for includes and libdir instead of hardcoding them

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
Herald added subscribers: arichardson, mgorny.
Herald added a project: All.
ldionne requested review of this revision.
Herald added projects: libc++, libc++abi.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.
Herald added a reviewer: libc++abi.

In the new-style testing configurations, we were hardcoding paths to the
`include` and `lib` directories, which was incorrect but always went
unnoticed because the hardcoded values always happened to match the
actual value.

When using new-style configs with the bootstrapping build, this falls
appart -- and we never noticed this because the bootstrapping build was
still using old style configs.

This patch removes the %{install} substitution, which makes it too
tempting to hardcode installation paths, and it also switches the
bootstrapping build to actually using new-style configs like we
always intended to do.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D121700

Files:
  libcxx/test/configs/apple-libc++-backdeployment.cfg.in
  libcxx/test/configs/apple-libc++-shared.cfg.in
  libcxx/test/configs/cmake-bridge.cfg.in
  libcxx/test/configs/ibm-libc++-shared.cfg.in
  libcxx/test/libcxx/vendor/apple/system-install-properties.sh.cpp
  libcxx/utils/ci/run-buildbot
  libcxx/utils/libcxx/test/config.py
  libcxxabi/test/configs/apple-libc++abi-backdeployment.cfg.in
  libcxxabi/test/configs/apple-libc++abi-shared.cfg.in
  libcxxabi/test/configs/cmake-bridge.cfg.in
  libcxxabi/test/configs/ibm-libc++abi-shared.cfg.in
  libcxxabi/test/vendor/apple/system-install-properties.sh.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D121700.415431.patch
Type: text/x-patch
Size: 13127 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220315/4ebe7e2a/attachment.bin>