[libcxx-commits] [PATCH] D119933: [demangler] Add support for C++20 modules

[Nathan Sidwell via Phabricator via libcxx-commits]

urnathan marked an inline comment as done.
urnathan added inline comments.


================
Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:2829-2835
+// <module-subname> ::= S <source-name>
+//		    ::= S P <source-name>
+template <typename Derived, typename Alloc>
+bool AbstractManglingParser<Derived, Alloc>::parseModuleNameOpt(
+    ModuleName *&Module) {
+  while (consumeIf('W')) {
+    bool IsPartition = consumeIf('P');
----------------
dblaikie wrote:
> Is the comment about `S` out of date, and should say `W` instead?
oops, I'd think'od that, it is indeed 'W'


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119933/new/

https://reviews.llvm.org/D119933