[libcxx-commits] [PATCH] D119933: [demangler] Add support for C++20 modules

[David Blaikie via Phabricator via libcxx-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

I don't have much context for the mangler, but this generally looks OK to me. (one minor question, probably just a comment update)



================
Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:2829-2835
+// <module-subname> ::= S <source-name>
+//		    ::= S P <source-name>
+template <typename Derived, typename Alloc>
+bool AbstractManglingParser<Derived, Alloc>::parseModuleNameOpt(
+    ModuleName *&Module) {
+  while (consumeIf('W')) {
+    bool IsPartition = consumeIf('P');
----------------
Is the comment about `S` out of date, and should say `W` instead?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119933/new/

https://reviews.llvm.org/D119933