[libcxx-commits] [PATCH] D121164: [libcxx] [ci] Check that Windows static libraries don't contain dllexports

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo updated this revision to Diff 416301.
mstorsjo added a comment.

Converted to a regular test as suggested. Unfortunately, the filename differs between clang-cl and mingw configs, so I duplicated the test (under vendor/mingw and vendor/clangcl) - not sure if there's any better way to have conditionals in this kind of test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121164/new/

https://reviews.llvm.org/D121164

Files:
  libcxx/test/libcxx/vendor/clangcl/static-lib-exports.sh.cpp
  libcxx/test/libcxx/vendor/mingw/static-lib-exports.sh.cpp


Index: libcxx/test/libcxx/vendor/mingw/static-lib-exports.sh.cpp
===================================================================
--- /dev/null
+++ libcxx/test/libcxx/vendor/mingw/static-lib-exports.sh.cpp
@@ -0,0 +1,19 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// REQUIRES: target={{.+}}-windows-gnu
+
+// This file checks that the built static library doesn't contain dllexport
+// directives.
+
+// RUN: llvm-readobj --coff-directives "%{lib}/libc++.a" | not grep -i "export:" > /dev/null
+
+// It's a known issue, that when building a shared library at the same time
+// as the static library, the generated static library does contain dllexport
+// directives.
+// XFAIL: windows-dll
Index: libcxx/test/libcxx/vendor/clangcl/static-lib-exports.sh.cpp
===================================================================
--- /dev/null
+++ libcxx/test/libcxx/vendor/clangcl/static-lib-exports.sh.cpp
@@ -0,0 +1,19 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// REQUIRES: msvc
+
+// This file checks that the built static library doesn't contain dllexport
+// directives.
+
+// RUN: llvm-readobj --coff-directives "%{lib}/libc++.lib" | not grep -i "export:" > /dev/null
+
+// It's a known issue, that when building a shared library at the same time
+// as the static library, the generated static library does contain dllexport
+// directives.
+// XFAIL: windows-dll


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D121164.416301.patch
Type: text/x-patch
Size: 2049 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220317/2bd9104b/attachment.bin>