[libcxx-commits] [PATCH] D121164: [libcxx] [ci] Check that Windows static libraries don't contain dllexports

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/utils/ci/run-buildbot:146
 
+function check-static-dllexports() {
+    echo "+++ Inspecting the built library"
----------------
I would like to implement these checks using a test like `libcxx/test/libcxx/vendor/apple/system-install-properties.sh.cpp` instead. I want to avoid bloating `run-buildbot` and adding logic to it. Also, we should be performing those checks when we run `ninja check-cxx`, not only when we run on the CI.

The infrastructure for these kinds of checks is still rather immature, but the idea is that I'd like upstream libc++ to have a place to perform vendor or platform specific checks as part of libc++'s own tests. For example, making sure that the `install_name` is the right one, that we re-export the right symbols, etc. And this would also extend to `check-cxx-abilist` -- I have a local patch that tries to move the abilist tests to that infrastructure, but it's not complete enough to publish.

In summary: I'd like to make `libcxx/test/libcxx/vendor` (we can bikeshed on a different directory name) the canonical place for these kinds of tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121164/new/

https://reviews.llvm.org/D121164